Update to Firefox version 140 #24
Open
+125
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes substantial changes to the build setup, including moving all of the dependency installation out of the shell script and into the CI workflow definition. Before, we were using the Firefox build system's support for installing toolchains. With this change, we instead install them manually. This means we're not tied to Mozilla's handling of toolchain artifacts, which is explicitly documented as only being supported for current versions of the Firefox codebase. In combination, these changes lead to faster and easier builds, and make it much easier to do local builds, too.
This contains more definitions than the `js-config.h` header which is already included, including vital ones determining the object layout for certain objects, and function signatures. Without these definitions, embeddings create subtly wrong results in very hard to debug ways, I can report from experience.
JakeChampion
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes substantial changes to the build setup, including moving all of the dependency installation out of the shell script and into the CI workflow definition.
Before, we were using the Firefox build system's support for installing toolchains. With this change, we instead install them manually. This means we're not tied to Mozilla's handling of toolchain artifacts, which is explicitly documented as only being supported for current versions of the Firefox codebase.
In combination, these changes lead to faster and easier builds, and make it much easier to do local builds, too.